Add TiFlash security configuration (#5094)#5130
Merged
TomShawn merged 2 commits intopingcap:release-4.0from Dec 18, 2020
Merged
Add TiFlash security configuration (#5094)#5130TomShawn merged 2 commits intopingcap:release-4.0from
TomShawn merged 2 commits intopingcap:release-4.0from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
10 tasks
Contributor
Author
|
@JaySon-Huang you're already a collaborator in bot's repo. |
TomShawn
reviewed
Dec 18, 2020
tiflash/tiflash-configuration.md
Outdated
Comment on lines
+86
to
+90
| [security] | ||
| ## 若开启该选项，日志中的用户数据会以 `?` 代替显示 | ||
| ## 注意，tiflash-learner 对应的安全配置选项为 `security.redact-info-log`，需要在 tiflash-learner.toml 中另外开启 | ||
| # redact_info_log = false | ||
|
|
Contributor
There was a problem hiding this comment.
@JaySon-Huang PTAL
Suggested change
| [security] | |
| ## 若开启该选项，日志中的用户数据会以 `?` 代替显示 | |
| ## 注意，tiflash-learner 对应的安全配置选项为 `security.redact-info-log`，需要在 tiflash-learner.toml 中另外开启 | |
| # redact_info_log = false |
Contributor
Author
|
@JaySon-Huang, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack). |
TomShawn
approved these changes
Dec 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #5094 to release-4.0
Signed-off-by: JaySon-Huang tshent@qq.com
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add document for security configuration in TiFlash.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?