Skip to content

dev/2.1/3.0/3.1/4.0: add global variable latency resulted by gvc.#2208

Merged
sre-bot merged 4 commits intopingcap:masterfrom
AilinKid:gvc_latency
Feb 4, 2020
Merged

dev/2.1/3.0/3.1/4.0: add global variable latency resulted by gvc.#2208
sre-bot merged 4 commits intopingcap:masterfrom
AilinKid:gvc_latency

Conversation

@AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Feb 4, 2020

What is changed, added or deleted?

What is the related PR or file link(s)?

  • Reference link(s): Issue #14531
  • This PR is to align with:
  • N/A (not applicable)

Which TiDB version(s) does your changes apply to?

  • All active versions: dev, v3.0, v2.1, v3.1
  • dev (the latest development version)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • v3.1 (TiDB 3.1 versions)
  • v4.0 (TiDB 4.0 versions)
  • All active and inactive versions
  • N/A (not applicable)

Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.

  • Updated one version first. Will update other versions after I get two LGTMs.

@AilinKid AilinKid requested review from july2993 and yikeke February 4, 2020 08:11
july2993
july2993 reviewed Feb 4, 2020
View reviewed changes
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yikeke
yikeke reviewed Feb 4, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes. Rest LGTM

dev/reference/configuration/tidb-server/mysql-variables.md Outdated

> **注意：**
>
> 在分布式 TiDB 中，`GLOBAL` 变量的设置都会持久化到存储层中，单个 TiDB 实例每 2s 会主动进行一次全变量的获取并形成 `gvc` (global variables cache) 缓存, 该缓存有效时间最多可持续 2 秒。在设置 `GLOBAL` 变量之后为了保证新会话能够有效，请确保两个操作之间的间隔大于 2 秒。相关细节可以查看 Issue [#14531](https://github.com/pingcap/tidb/issues/14531)。
Copy link
Contributor

@yikeke yikeke Feb 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> 在分布式 TiDB 中，`GLOBAL` 变量的设置都会持久化到存储层中，单个 TiDB 实例每 2s 会主动进行一次全变量的获取并形成 `gvc` (global variables cache) 缓存, 该缓存有效时间最多可持续 2 秒。在设置 `GLOBAL` 变量之后为了保证新会话能够有效，请确保两个操作之间的间隔大于 2 秒。相关细节可以查看 Issue [#14531](https://github.com/pingcap/tidb/issues/14531)。
> 在分布式 TiDB 中，`GLOBAL` 变量的设置会持久化到存储层中，单个 TiDB 实例每 2 秒会主动进行一次全变量的获取并形成 `gvc` (global variables cache) 缓存，该缓存有效时间最多可持续 2 秒。在设置 `GLOBAL` 变量之后，为了保证新会话的有效性，请确保两个操作之间的间隔大于 2 秒。相关细节可以查看 [Issue #14531](https://github.com/pingcap/tidb/issues/14531)。

v2.1/reference/configuration/tidb-server/mysql-variables.md Outdated

> **注意：**
>
> 在分布式 TiDB 中，`GLOBAL` 变量的设置都会持久化到存储层中，单个 TiDB 实例每 2s 会主动进行一次全变量的获取并形成 `gvc` (global variables cache) 缓存, 该缓存有效时间最多可持续 2 秒。在设置 `GLOBAL` 变量之后为了保证新会话能够有效，请确保两个操作之间的间隔大于 2 秒。相关细节可以查看 Issue [#14531](https://github.com/pingcap/tidb/issues/14531)。
Copy link
Contributor

@yikeke yikeke Feb 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> 在分布式 TiDB 中，`GLOBAL` 变量的设置都会持久化到存储层中，单个 TiDB 实例每 2s 会主动进行一次全变量的获取并形成 `gvc` (global variables cache) 缓存, 该缓存有效时间最多可持续 2 秒。在设置 `GLOBAL` 变量之后为了保证新会话能够有效，请确保两个操作之间的间隔大于 2 秒。相关细节可以查看 Issue [#14531](https://github.com/pingcap/tidb/issues/14531)。
> 在分布式 TiDB 中，`GLOBAL` 变量的设置会持久化到存储层中，单个 TiDB 实例每 2 秒会主动进行一次全变量的获取并形成 `gvc` (global variables cache) 缓存，该缓存有效时间最多可持续 2 秒。在设置 `GLOBAL` 变量之后，为了保证新会话的有效性，请确保两个操作之间的间隔大于 2 秒。相关细节可以查看 [Issue #14531](https://github.com/pingcap/tidb/issues/14531)。

v3.0/reference/configuration/tidb-server/mysql-variables.md Outdated

> **注意：**
>
> 在分布式 TiDB 中，`GLOBAL` 变量的设置都会持久化到存储层中，单个 TiDB 实例每 2s 会主动进行一次全变量的获取并形成 `gvc` (global variables cache) 缓存, 该缓存有效时间最多可持续 2 秒。在设置 `GLOBAL` 变量之后为了保证新会话能够有效，请确保两个操作之间的间隔大于 2 秒。相关细节可以查看 Issue [#14531](https://github.com/pingcap/tidb/issues/14531)。
Copy link
Contributor

@yikeke yikeke Feb 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> 在分布式 TiDB 中，`GLOBAL` 变量的设置都会持久化到存储层中，单个 TiDB 实例每 2s 会主动进行一次全变量的获取并形成 `gvc` (global variables cache) 缓存, 该缓存有效时间最多可持续 2 秒。在设置 `GLOBAL` 变量之后为了保证新会话能够有效，请确保两个操作之间的间隔大于 2 秒。相关细节可以查看 Issue [#14531](https://github.com/pingcap/tidb/issues/14531)。
> 在分布式 TiDB 中，`GLOBAL` 变量的设置会持久化到存储层中，单个 TiDB 实例每 2 秒会主动进行一次全变量的获取并形成 `gvc` (global variables cache) 缓存，该缓存有效时间最多可持续 2 秒。在设置 `GLOBAL` 变量之后，为了保证新会话的有效性，请确保两个操作之间的间隔大于 2 秒。相关细节可以查看 [Issue #14531](https://github.com/pingcap/tidb/issues/14531)。

v3.1/reference/configuration/tidb-server/mysql-variables.md Outdated

> **注意：**
>
> 在分布式 TiDB 中，`GLOBAL` 变量的设置都会持久化到存储层中，单个 TiDB 实例每 2s 会主动进行一次全变量的获取并形成 `gvc` (global variables cache) 缓存, 该缓存有效时间最多可持续 2 秒。在设置 `GLOBAL` 变量之后为了保证新会话能够有效，请确保两个操作之间的间隔大于 2 秒。相关细节可以查看 Issue [#14531](https://github.com/pingcap/tidb/issues/14531)。
Copy link
Contributor

@yikeke yikeke Feb 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> 在分布式 TiDB 中，`GLOBAL` 变量的设置都会持久化到存储层中，单个 TiDB 实例每 2s 会主动进行一次全变量的获取并形成 `gvc` (global variables cache) 缓存, 该缓存有效时间最多可持续 2 秒。在设置 `GLOBAL` 变量之后为了保证新会话能够有效，请确保两个操作之间的间隔大于 2 秒。相关细节可以查看 Issue [#14531](https://github.com/pingcap/tidb/issues/14531)。
> 在分布式 TiDB 中，`GLOBAL` 变量的设置会持久化到存储层中，单个 TiDB 实例每 2 秒会主动进行一次全变量的获取并形成 `gvc` (global variables cache) 缓存，该缓存有效时间最多可持续 2 秒。在设置 `GLOBAL` 变量之后，为了保证新会话的有效性，请确保两个操作之间的间隔大于 2 秒。相关细节可以查看 [Issue #14531](https://github.com/pingcap/tidb/issues/14531)。

@yikeke yikeke added translation/doing This PR’s assignee is translating this PR. size/small Changes of a small size. labels Feb 4, 2020
@AilinKid AilinKid changed the title dev: add global variable latency resulted by gvc. dev/2.1/3.0/3.1/4.0: add global variable latency resulted by gvc. Feb 4, 2020
yikeke
yikeke approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the status/can-merge Indicates a PR has been approved by a committer. label Feb 4, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 4, 2020

/run-all-tests

@sre-bot sre-bot merged commit d6b67a5 into pingcap:master Feb 4, 2020
@toutdesuite toutdesuite mentioned this pull request Feb 6, 2020
Merged
12 tasks
@toutdesuite toutdesuite added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 17, 2020
@xhebox xhebox mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@july2993 july2993 july2993 left review comments

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@toutdesuite toutdesuite

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AilinKid @sre-bot @july2993 @yikeke @toutdesuite