Skip to content

[TiDB] Add new mode option prefer-leader for tidb_replica_read.#12865

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
LykxSassinator:0201-prefer-leader
Feb 10, 2023
Merged

[TiDB] Add new mode option prefer-leader for tidb_replica_read.#12865
ti-chi-bot merged 4 commits intopingcap:masterfrom
LykxSassinator:0201-prefer-leader

Conversation

@LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Feb 1, 2023 •
edited
Loading

Signed-off-by: Lucasliang nkcs_lykx@hotmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a new mode prefer-leader for the system variable tidb_replica_read.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@LykxSassinator
Add new mode option prefer-leader for tidb_replica_read.
9cd5c6c 
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 1, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from qiancai February 1, 2023 02:40
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 1, 2023
@LykxSassinator LykxSassinator changed the title Add new mode option prefer-leader for tidb_replica_read. [TiDB] Add new mode option prefer-leader for tidb_replica_read. Feb 1, 2023
@LykxSassinator LykxSassinator mentioned this pull request Feb 1, 2023
Merged
15 tasks
@TomShawn TomShawn assigned TomShawn and LykxSassinator and unassigned TomShawn Feb 1, 2023
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.6 area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. and removed missing-translation-status This PR does not have translation status info. labels Feb 1, 2023
@TomShawn TomShawn requested review from easonn7 and removed request for qiancai February 1, 2023 03:03
@TomShawn TomShawn self-assigned this Feb 1, 2023
@LykxSassinator
Polish docs.
a746541 
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
TomShawn
TomShawn reviewed Feb 3, 2023
View reviewed changes
TomShawn
TomShawn reviewed Feb 3, 2023
View reviewed changes
LykxSassinator and others added 2 commits February 3, 2023 11:40
@LykxSassinator @TomShawn
Update develop/dev-guide-use-follower-read.md
3f88a19 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@LykxSassinator @TomShawn
Update follower-read.md
78bd607 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 3, 2023
@LykxSassinator LykxSassinator mentioned this pull request Feb 7, 2023
Merged
12 tasks
@LykxSassinator
Copy link
Contributor Author

LykxSassinator commented Feb 9, 2023

@TomShawn As all related PRs merged, this pr can be merged now.

@TomShawn
Copy link
Contributor

TomShawn commented Feb 9, 2023

This PR needs approval by @easonn7.

easonn7
easonn7 approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@easonn7 easonn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

TomShawn commented Feb 10, 2023

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 10, 2023
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 10, 2023
@TomShawn
Copy link
Contributor

TomShawn commented Feb 10, 2023

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 10, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 78bd607

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 10, 2023
@ti-chi-bot ti-chi-bot merged commit d06b8c9 into pingcap:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@TomShawn TomShawn TomShawn approved these changes

@easonn7 easonn7 easonn7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LykxSassinator LykxSassinator

@TomShawn TomShawn

Labels

area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LykxSassinator @ti-chi-bot @TomShawn @easonn7