Add descriptions of new panels and update the plan cache doc by fzzf678 · Pull Request #11799 · pingcap/docs-cn

fzzf678 · 2022-10-26T08:35:56Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Add descriptions about Plan Cache Memory Usage and Plan Cache Plan Num
Update plan cache doc

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):
planner: add monitor for prepared plan cache memory usage tidb#38507

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2022-10-26T08:35:58Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Oreoxmt
hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

fzzf678 · 2022-10-26T08:54:24Z

/cc @qw4990 PTAL

ti-chi-bot · 2022-10-26T08:54:26Z

@fzzf678: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @qw4990 PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sql-prepared-plan-cache.md

Co-authored-by: Aolin <aolinz@outlook.com>

qw4990 · 2022-10-27T03:12:59Z

sql-prepared-plan-cache.md

-比如目前 TiDB 实例的 `SESSION` 并发数是 50，平均每个 `SESSION` 大致缓存 100 个计划，则总内存开销为 `50 * 100 * 100KiB` 约等于 `512MB`。
+> **注意：**
+>
+> 考虑到 Golang 的内存回收机制以及部分未统计的内存结构，Grafana 中显示的内存与实际的堆内存使用量并不相等。经过实验验证存在约 X0% 的误差。


这边测好了么，目前应该大概是 20%?

这边测好了么，目前应该大概是 20%?

目前的用的case测出来最高是20%多

Oreoxmt

LGTM

fzzf678 · 2022-10-27T06:40:48Z

/hold

sql-prepared-plan-cache.md

hfxsd

Rest LGTM

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

TomShawn

LGTM

hfxsd

LGTM

sql-prepared-plan-cache.md

Co-authored-by: fzzf678 <108643977+fzzf678@users.noreply.github.com>

TomShawn · 2022-11-07T02:47:27Z

/merge

ti-chi-bot · 2022-11-07T02:47:30Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: de4b367

fix

b2bd3a0

ti-chi-bot requested a review from TomShawn October 26, 2022 08:36

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2022

Oreoxmt added the v6.4 This PR/issue applies to TiDB v6.4. label Oct 26, 2022

Update sql-prepared-plan-cache.md

94d3eac

Oreoxmt assigned TomShawn Oct 26, 2022

Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Oct 26, 2022

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Oct 26, 2022

Oreoxmt self-requested a review October 26, 2022 08:49

Update sql-prepared-plan-cache.md

74d7d0f

Oreoxmt added the area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. label Oct 26, 2022

ti-chi-bot requested a review from qw4990 October 26, 2022 08:54

Oreoxmt reviewed Oct 26, 2022

View reviewed changes

sql-prepared-plan-cache.md Outdated Show resolved Hide resolved

sql-prepared-plan-cache.md Outdated Show resolved Hide resolved

sql-prepared-plan-cache.md Outdated Show resolved Hide resolved

sql-prepared-plan-cache.md Outdated Show resolved Hide resolved

Oreoxmt self-requested a review October 26, 2022 09:03

Apply suggestions from code review

159c112

Co-authored-by: Aolin <aolinz@outlook.com>

fzzf678 mentioned this pull request Oct 27, 2022

planner: Memory tracking for plan cache pingcap/tidb#37632

Closed

25 tasks

qw4990 reviewed Oct 27, 2022

View reviewed changes

Oreoxmt requested a review from hfxsd October 27, 2022 06:37

Oreoxmt approved these changes Oct 27, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2022

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2022

hfxsd reviewed Oct 27, 2022

View reviewed changes

sql-prepared-plan-cache.md Outdated Show resolved Hide resolved

hfxsd approved these changes Oct 27, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 27, 2022

Apply suggestions from code review

b25ddc2

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

Oreoxmt requested a review from qw4990 October 28, 2022 08:36

loss

e0a8954

TomShawn approved these changes Oct 31, 2022

View reviewed changes

TomShawn mentioned this pull request Nov 1, 2022

Add descriptions of new panels and update the plan cache doc pingcap/docs#11110

Merged

13 tasks

hfxsd approved these changes Nov 3, 2022

View reviewed changes

fzzf678 commented Nov 4, 2022

View reviewed changes

sql-prepared-plan-cache.md Outdated Show resolved Hide resolved

qw4990 approved these changes Nov 4, 2022

View reviewed changes

TomShawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022

Update sql-prepared-plan-cache.md

de4b367

Co-authored-by: fzzf678 <108643977+fzzf678@users.noreply.github.com>

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022

ti-chi-bot merged commit 5f7ad64 into pingcap:master Nov 7, 2022

Conversation

fzzf678 commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

ti-chi-bot commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fzzf678 commented Oct 26, 2022

Uh oh!

ti-chi-bot commented Oct 26, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qw4990 Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

fzzf678 Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

Oreoxmt left a comment

Choose a reason for hiding this comment

Uh oh!

fzzf678 commented Oct 27, 2022

Uh oh!

Uh oh!

hfxsd left a comment

Choose a reason for hiding this comment

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

hfxsd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TomShawn commented Nov 7, 2022

Uh oh!

ti-chi-bot commented Nov 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fzzf678 commented Oct 26, 2022 •

edited

Loading

ti-chi-bot commented Oct 26, 2022 •

edited

Loading