add a better clarification on how sysvar changes "propagate" (#5562)#5641
Merged
ti-chi-bot merged 2 commits intopingcap:release-4.0from May 18, 2021
Merged
Conversation
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
10 tasks
TomShawn
approved these changes
May 18, 2021
Member
Author
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
Contributor
|
/merge |
Member
Author
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 83b6a4f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5562
What is changed, added or deleted? (Required)
The sysvar docs imply that the 2 second delay is propagation to other servers. This is not the case, there is no propagation at all, because the table is stored in TiKV. The delay is the global values cache, and thus it affects the issuing server as well.
This affects all versions, but master will hopefully have a fix soon so I'll create a separate PR to document the different semantics.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
For GA releases it is pingcap/tidb#22808
(I will leave the issue open until master is fixed)
Do your changes match any of the following descriptions?