system-variables: Merge with tidb-specific-sysvars (#3152)#3261
Merged
ti-srebot merged 4 commits intopingcap:release-4.0from Jul 14, 2020
Merged
system-variables: Merge with tidb-specific-sysvars (#3152)#3261ti-srebot merged 4 commits intopingcap:release-4.0from
ti-srebot merged 4 commits intopingcap:release-4.0from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
5 tasks
Contributor
|
Please help delete tidb-specific-system-variables.md. @nullnotnil (P.S. Cherry-picker bot can't delete files because of a known bug) |
yikeke
reviewed
Jul 14, 2020
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
|
@yikeke |
yikeke
reviewed
Jul 14, 2020
Contributor
|
/merge |
Contributor
Author
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #3152 to release-4.0
What is changed, added or deleted? (Required)
This PR proposes merging the system-variables and tidb-specific-system-variables documents together.
The motivation for this, is that they both have the same semantics. It is just a namespace that differs, but this can clearly be visible by sorting the variables in alphabetical order (something else I've done.)
In the process of creating this PR, I discovered that several sysvars are undocumented. I have created #3155 to handle separately.
Also,
SHARD_ROW_ID_BITSwas documented as a system variable but it is not. I have moved it to the statement reference forCREATE TABLEandALTER TABLE.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
This is original work.