Skip to content

Add persistent statements summary#12069

Merged
ti-chi-bot merged 16 commits intopingcap:masterfrom
mornyx:stmtsummary
Feb 13, 2023
Merged

Add persistent statements summary#12069
ti-chi-bot merged 16 commits intopingcap:masterfrom
mornyx:stmtsummary

Conversation

@mornyx
Copy link
Contributor

@mornyx mornyx commented Jan 16, 2023 •
edited by shichun-0415
Loading

Signed-off-by: mornyx mornyx.z@gmail.com

What is changed, added or deleted? (Required)

Add documentation for a new experimental feature: Persistent Statements Summary.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

mornyx added 2 commits January 16, 2023 15:55
@mornyx
Add persistent statements summary
bca6ac6 
Signed-off-by: mornyx <mornyx.z@gmail.com>
@mornyx
Add description
62e2e1c 
Signed-off-by: mornyx <mornyx.z@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2023
@ti-chi-bot ti-chi-bot requested a review from TomShawn January 16, 2023 08:03
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2023
@mornyx mornyx mentioned this pull request Jan 16, 2023
Merged
14 tasks
@mornyx mornyx changed the title Stmtsummary Add persistent statements summary Jan 16, 2023
@shichun-0415 shichun-0415 added translation/doing This PR's assignee is translating this PR. area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. v6.6 type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. translation/doing This PR's assignee is translating this PR. labels Jan 16, 2023
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Jan 16, 2023
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2023
@mornyx mornyx mentioned this pull request Jan 29, 2023
Merged
12 tasks
@mornyx
Rename configurations
4aa381a 
Signed-off-by: mornyx <mornyx.z@gmail.com>
@shichun-0415 shichun-0415 requested review from shichun-0415 and removed request for TomShawn January 30, 2023 07:59
@mornyx mornyx marked this pull request as ready for review January 30, 2023 08:00
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2023
@mornyx
Merge branch 'master' into stmtsummary
fe9303b 
Signed-off-by: mornyx <mornyx.z@gmail.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2023
@shichun-0415
Copy link
Contributor

shichun-0415 commented Feb 6, 2023

/cc @Oreoxmt

Oreoxmt
Oreoxmt reviewed Feb 6, 2023
View reviewed changes
@Oreoxmt Oreoxmt self-requested a review February 6, 2023 07:53
mornyx and others added 2 commits February 6, 2023 16:12
Oreoxmt
Oreoxmt reviewed Feb 7, 2023
View reviewed changes
@Oreoxmt Oreoxmt self-requested a review February 8, 2023 14:03
Oreoxmt
Oreoxmt approved these changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2023
@shichun-0415 @Oreoxmt
Apply suggestions from code review
00f4a02 
Co-authored-by: Aolin <aolinz@outlook.com>
qiancai
qiancai reviewed Feb 13, 2023
View reviewed changes
qiancai
qiancai reviewed Feb 13, 2023
View reviewed changes
@shichun-0415 @qiancai
Apply suggestions from code review
c4fd0be 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2023
@shichun-0415
Copy link
Contributor

shichun-0415 commented Feb 13, 2023

/verify

shichun-0415
shichun-0415 approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 13, 2023
@shichun-0415
Copy link
Contributor

shichun-0415 commented Feb 13, 2023

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 13, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: c4fd0be

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 13, 2023
@ti-chi-bot ti-chi-bot merged commit 4f228da into pingcap:master Feb 13, 2023
@mornyx mornyx deleted the stmtsummary branch February 13, 2023 08:53
@shichun-0415 shichun-0415 mentioned this pull request Feb 15, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiancai qiancai qiancai left review comments

@Oreoxmt Oreoxmt Oreoxmt approved these changes

+2 more reviewers

@zhongzc zhongzc zhongzc approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shichun-0415 shichun-0415

Labels

area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mornyx @ti-chi-bot @shichun-0415 @zhongzc @Oreoxmt @qiancai