Skip to content

promote morgo to committer#398

Merged
ti-chi-bot merged 1 commit intopingcap:masterfrom
tangenta:update-mem
Jan 29, 2021
Merged

promote morgo to committer#398
ti-chi-bot merged 1 commit intopingcap:masterfrom
tangenta:update-mem

Conversation

@tangenta
Copy link
Contributor

@tangenta tangenta commented Jan 27, 2021

@morgo now satisfies the requirements for being promoted to a committer.

Requirements

  • Have at least 20 PRs merged.
  • Have reviewed at least 10 PRs.
  • Nominated by at least 2 Committers or Maintainers.

@ghost
Copy link

ghost commented Jan 27, 2021

Sig file formatting success.

@ti-chi-bot ti-chi-bot requested review from coocood and shenli January 27, 2021 04:41
@tangenta tangenta changed the title promote morgo to reviewer promote morgo to committer Jan 27, 2021
djshow832
djshow832 reviewed Jan 27, 2021
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Jan 27, 2021

LGTM

@bb7133
Copy link
Member

bb7133 commented Jan 27, 2021

PTAL @hi-rustin @sykp241095

@0xPoe
Copy link
Member

0xPoe commented Jan 27, 2021

PTAL @hi-rustin @sykp241095

Please use /lgtm or directly approve the PR.

@tangenta
Copy link
Contributor Author

tangenta commented Jan 28, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 28, 2021

@tangenta: you cannot /lgtm your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@0xPoe
Copy link
Member

0xPoe commented Jan 29, 2021

/cc @djshow832 @bb7133

@tiancaiamao
Copy link
Contributor

tiancaiamao commented Jan 29, 2021

LGTM

@0xPoe
Copy link
Member

0xPoe commented Jan 29, 2021

LGTM

Please use /LGTM.

@tiancaiamao
Copy link
Contributor

tiancaiamao commented Jan 29, 2021

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 29, 2021
@bb7133
Copy link
Member

bb7133 commented Jan 29, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 29, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 29, 2021
@tiancaiamao
Copy link
Contributor

tiancaiamao commented Jan 29, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 29, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7c92d4b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 29, 2021
@ti-chi-bot ti-chi-bot merged commit e5abb07 into pingcap:master Jan 29, 2021
@ghost
Copy link

ghost commented Jan 29, 2021

Update sig info success.

@tiancaiamao tiancaiamao mentioned this pull request Jan 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coocood coocood Awaiting requested review from coocood

@shenli shenli Awaiting requested review from shenli

@bb7133 bb7133 Awaiting requested review from bb7133

@djshow832 djshow832 Awaiting requested review from djshow832

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tangenta @bb7133 @0xPoe @ti-chi-bot @tiancaiamao @djshow832