This repository was archived by the owner on Jul 24, 2024. It is now read-only.
*: merging tidb-lightning (#665)#740
Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.0-rcfrom
Closed
*: merging tidb-lightning (#665)#740ti-srebot wants to merge 1 commit intopingcap:release-5.0-rcfrom
ti-srebot wants to merge 1 commit intopingcap:release-5.0-rcfrom
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Member
|
We are not going to merging tidb-lightning into release-5.0-rc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #665 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr https://github.com/pingcap/br/pull/740After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Merging TiDB-Lightning repo into BR repo.
What is changed and how it works?
git subtree add -P pkg/lightning https://github.com/pingcap/br/pkg/lightning.gitinsubtree-lightningbranch.This PR targets to
subtree-lightningbranch for easier review, also it includes changes on import path and lightning tests (to pass BR CI).Check List
Tests
Side effects
Related changes
Release Note