This repository was archived by the owner on Jul 24, 2024. It is now read-only.
fill size in SSTMeta (#233)#702
Merged
3pointer merged 1 commit intopingcap:release-4.0from Jan 19, 2021
Merged
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Merged
Contributor
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
Collaborator
|
/run-all-tests |
Collaborator
|
/rebuild |
Member
|
Please add a version check, otherwise it may cause TiKV panic. |
Collaborator
Member
|
LGTM Please also add a test in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #233 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr https://github.com/pingcap/br/pull/702After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Fix #163
What is changed and how it works?
fill size in sstmeta. but we need make sure this change work on tikv which has this
tikv/tikv#7256, otherwise it will panic tikv.
Check List
Tests
Code changes
Side effects
Related changes
Release note