This repository was archived by the owner on Jul 24, 2024. It is now read-only.
progress: removed the progress struct (#561)#564
Merged
3pointer merged 3 commits intopingcap:release-4.0from Oct 23, 2020
Merged
progress: removed the progress struct (#561)#5643pointer merged 3 commits intopingcap:release-4.0from
3pointer merged 3 commits intopingcap:release-4.0from
Conversation
Collaborator
|
/build
|
Collaborator
|
/run-integration-test |
Collaborator
|
LGTM |
3pointer
approved these changes
Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #561 to release-4.0
What problem does this PR solve?
remove the progress struct.
This struct was error-prone(It has multi send-part but only close once, hence may leading to
send on closed channel), hence we embedded its function to an atomic integer inProgressPrinter.What is changed and how it works?
Remove the struct
glue.progress, implementglue.ProgressforProgressPrinterdirectly.This may cause the progress value won't immediately be added when calling
Inc. But we update the progress status by polling the progress every second, it would be ok to not react immediately.Check List
Tests
Release Note