Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

storage: support s3 seek end (#476)#489

Merged
ti-srebot merged 20 commits intopingcap:release-4.0from
ti-srebot:release-4.0-0fcfd5be4b93
Sep 8, 2020
Merged

storage: support s3 seek end (#476)#489
ti-srebot merged 20 commits intopingcap:release-4.0from
ti-srebot:release-4.0-0fcfd5be4b93

Conversation

@ti-srebot
Copy link
Contributor

cherry-pick #476 to release-4.0


What problem does this PR solve?

support seek by io.SeekEnd because parquet reader need to read file meta from file footer.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

Release Note

  • No release note

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Sep 4, 2020
@ti-srebot ti-srebot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Sep 8, 2020
@glorv
Copy link
Collaborator

glorv commented Sep 8, 2020

/run-all-tests

@glorv
Copy link
Collaborator

glorv commented Sep 8, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 491

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@glorv
Copy link
Collaborator

glorv commented Sep 8, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 4e68a8d into pingcap:release-4.0 Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants