Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Fix CI failed with "tikv timeout"#481

Merged
ti-srebot merged 2 commits intopingcap:masterfrom
YuJuncen:fix-timeout
Aug 31, 2020
Merged

Fix CI failed with "tikv timeout"#481
ti-srebot merged 2 commits intopingcap:masterfrom
YuJuncen:fix-timeout

Conversation

@YuJuncen
Copy link
Collaborator

@YuJuncen YuJuncen commented Aug 31, 2020

Signed-off-by: Hillium maruruku@stu.csust.edu.cn

What problem does this PR solve?

Fix CI failed with "tikv timeout"

What is changed and how it works?

Currently, when a lock resolved, the continuing proto message would be incorrect(for unknown reason).
We would get errors like:

grpc: failed to unmarshal the received message proto: wrong wireType = 2 for field UseAsyncCommit

After updating kvproto, the problem seems resolved magically(!).

Check List

Tests

  • Integration test

Release Note

  • No release note

Hillium added 2 commits August 31, 2020 16:37
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
Signed-off-by: Hillium <maruruku@stu.csust.edu.cn>
@YuJuncen
Copy link
Collaborator Author

/run-integration-test

can it resolve the problem stable?

Copy link
Collaborator

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should find which PR bring the fail later

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Aug 31, 2020
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGTM1 label Aug 31, 2020
@ti-srebot ti-srebot added the status/LGT2 LGTM2 label Aug 31, 2020
@YuJuncen
Copy link
Collaborator Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants