Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

restore: switch mode immediately when restore start.#473

Merged
kennytm merged 2 commits intopingcap:masterfrom
3pointer:switch_mode
Aug 26, 2020
Merged

restore: switch mode immediately when restore start.#473
kennytm merged 2 commits intopingcap:masterfrom
3pointer:switch_mode

Conversation

@3pointer
Copy link
Collaborator

@3pointer 3pointer commented Aug 26, 2020

What problem does this PR solve?

Fix the issue that switch to import mode not work at first 5 minutes.

What is changed and how it works?

do switchToImportMode at first.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    There is no "switch to import mode" log if we finish restore in 5 minutes.

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • Fix the issue that switch to import mode not work at first 5 minutes.

@3pointer 3pointer requested a review from overvenus August 26, 2020 11:02
@3pointer 3pointer requested review from glorv and kennytm August 26, 2020 11:12
glorv
glorv reviewed Aug 26, 2020
View reviewed changes
Copy link
Collaborator

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 26, 2020

@glorv,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: tools(slack).

overvenus
overvenus approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Aug 26, 2020
@kennytm kennytm merged commit 3234e8d into pingcap:master Aug 26, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 26, 2020
Merged
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 26, 2020

cherry pick to release-4.0 in PR #474

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kennytm kennytm Awaiting requested review from kennytm

2 more reviewers

@glorv glorv glorv left review comments

@overvenus overvenus overvenus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-4.0 status/LGT1 LGTM1 type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@3pointer @ti-srebot @overvenus @glorv @kennytm