Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

update tidb / tidb-tools dependencies#466

Merged
overvenus merged 1 commit intopingcap:masterfrom
HunDunDM:update-pd-3
Aug 20, 2020
Merged

update tidb / tidb-tools dependencies#466
overvenus merged 1 commit intopingcap:masterfrom
HunDunDM:update-pd-3

Conversation

@HunDunDM
Copy link
Contributor

Signed-off-by: Zheng Xiangsheng hundundm@gmail.com

What problem does this PR solve?

This PR is the stage 3 of pingcap/tidb#19306 , in order to upgrade the PD dependency of tidb related repo.

Check List

Tests

  • Unit test

Release Note

  • update pd dependencies

Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Aug 20, 2020
@ti-srebot ti-srebot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Aug 20, 2020
@HunDunDM
Copy link
Contributor Author

Is there any problem?

@kennytm
Copy link
Collaborator

kennytm commented Aug 20, 2020

the integration test is still running (seems to be stuck)

@overvenus
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@overvenus
Copy link
Member

/run-integration-test

@overvenus
Copy link
Member

Confirmed test stuck due to PD server panic

[2020-08-20T10:19:01.244Z] [2020/08/20 17:40:37.026 +08:00] [FATAL] [log.go:292] [panic] [recover="\"invalid memory address or nil pointer dereference\""] [stack="github.com/pingcap/log.Fatal\n\t/home/jenkins/agent/workspace/build_pd_multi_branch_master/go/pkg/mod/github.com/pingcap/log@v0.0.0-20200511115504-543df19646ad/global.go:59\ngithub.com/tikv/pd/pkg/logutil.LogPanic\n\t/home/jenkins/agent/workspace/build_pd_multi_branch_master/go/src/github.com/pingcap/pd/pkg/logutil/log.go:292\nruntime.gopanic\n\t/usr/local/go/src/runtime/panic.go:679\nruntime.panicmem\n\t/usr/local/go/src/runtime/panic.go:199\nruntime.sigpanic\n\t/usr/local/go/src/runtime/signal_unix.go:394\nsync.(*RWMutex).RLock\n\t/usr/local/go/src/sync/rwmutex.go:48\ngithub.com/tikv/pd/server/statistics.(*RollingStoreStats).GetBytesRate\n\t/home/jenkins/agent/workspace/build_pd_multi_branch_master/go/src/github.com/pingcap/pd/server/statistics/store.go:387\ngithub.com/tikv/pd/server/statistics.(*storeStatistics).Observe\n\t/home/jenkins/agent/workspace/build_pd_multi_branch_master/go/src/github.com/pingcap/pd/server/statistics/store_collection.go:107\ngithub.com/tikv/pd/server/statistics.(*storeStatisticsMap).Observe\n\t/home/jenkins/agent/workspace/build_pd_multi_branch_master/go/src/github.com/pingcap/pd/server/statistics/store_collection.go:221\ngithub.com/tikv/pd/server/cluster.(*RaftCluster).collectMetrics\n\t/home/jenkins/agent/workspace/build_pd_multi_branch_master/go/src/github.com/pingcap/pd/server/cluster/cluster.go:1199\ngithub.com/tikv/pd/server/cluster.(*RaftCluster).runBackgroundJobs\n\t/home/jenkins/agent/workspace/build_pd_multi_branch_master/go/src/github.com/pingcap/pd/server/cluster/cluster.go:319"]

@ti-srebot
Copy link
Contributor

@HunDunDM merge failed.

@overvenus
Copy link
Member

/run-integration-test

@overvenus
Copy link
Member

I'm going to merge this PR as failed test is caused by a bug from PD.

@overvenus overvenus merged commit 01ac048 into pingcap:master Aug 20, 2020
@HunDunDM HunDunDM deleted the update-pd-3 branch August 20, 2020 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants