Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

storage: use path in WalkDir and Open (#459)#464

Merged
3pointer merged 6 commits intopingcap:release-4.0from
ti-srebot:release-4.0-3b5df22963a9
Aug 20, 2020
Merged

storage: use path in WalkDir and Open (#459)#464
3pointer merged 6 commits intopingcap:release-4.0from
ti-srebot:release-4.0-3b5df22963a9

Conversation

@ti-srebot
Copy link
Contributor

cherry-pick #459 to release-4.0


Signed-off-by: glorv glorvs@163.com

What problem does this PR solve?

Use file path in ExtrenalStorage method WalkDir and Open

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has interface methods change

Side effects

Related changes

Release Note

  • No release note

@kennytm
Copy link
Collaborator

kennytm commented Aug 18, 2020

lgtm

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Aug 18, 2020
Copy link
Collaborator

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Aug 20, 2020
@3pointer 3pointer merged commit 6f48a22 into pingcap:release-4.0 Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants