This repository was archived by the owner on Jul 24, 2024. It is now read-only.
storage: extend the ExternalStorage interface and implements (#446)#462
Merged
3pointer merged 1 commit intopingcap:release-4.0from Aug 17, 2020
Merged
storage: extend the ExternalStorage interface and implements (#446)#4623pointer merged 1 commit intopingcap:release-4.0from
ExternalStorage interface and implements (#446)#4623pointer merged 1 commit intopingcap:release-4.0from
Conversation
…ap#446) * update storage * update * fix * export s3 flags * fix local path * fix s3 reader * fix range offset * fix the req range errors * fix comments * fix review comments * fix some comments * update * fix * update Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Collaborator
|
can we pick #456 here as well? or do it in a separate PR? |
Collaborator
I'll do it in another PR after this PR merged |
kennytm
approved these changes
Aug 17, 2020
ti-srebot
approved these changes
Aug 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry-pick #446 to release-4.0
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release Note