This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[cherry-pick] remove scheduler(#426)#431
Merged
ti-srebot merged 3 commits intopingcap:release-4.0from Jul 22, 2020
Merged
Conversation
* *: move remove schedulers logic out from restore. * task: add flag of remove scheduler * tests: add tests of remove scheduler * task: move remove-scheduler flag to backup config * backup: return staged undo function. Signed-off-by: Hillium <maruruku@stu.csust.edu.cn> * conn, backup: run undo anyway. Signed-off-by: Hillium <maruruku@stu.csust.edu.cn> * backup: hide remove schedulers flag Signed-off-by: Hillium <maruruku@stu.csust.edu.cn> Co-authored-by: 3pointer <luancheng@pingcap.com>
Contributor
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
Collaborator
Author
|
/run-all-tests |
kennytm
approved these changes
Jul 22, 2020
ti-srebot
approved these changes
Jul 22, 2020
Collaborator
|
/merge |
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixed #412.
What is changed and how it works?
Firstly, we extract the logic of removing schedulers to
connpackage, as a method ofconn.Manager.Then, we add a flag that controls whether to remove scheduler when backing up.
Finally, we call the extracted method on backup if the flag is set.
Check List
Tests
Release Note