This repository was archived by the owner on Jul 24, 2024. It is now read-only.
cherry pick #402 and #396 to release 4.0.#410
Merged
kennytm merged 2 commits intopingcap:release-4.0from Jul 9, 2020
Merged
Conversation
…pingcap#396) * *: run BackupRanges in parallel, change meaning of backup concurrency * backup: fix overestimated time summary * backup,task: refactor: remove backupMeta field from backup.Client This avoids the implicit race due to mutating hidden members. Instead, we use functional style (build the backupMeta bottom-up from immutable bits) to eliminate the race conditions. Co-authored-by: 3pointer <luancheng@pingcap.com>
* backup: set syncpoint at background * backup: use real duration * backup: run check safepoint at background * backup: fix some errors after merging * backup: fix some problems * backup: ensure all files are collected. * backup: use select to sync files * backup: don't select on errCh Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Contributor
|
@kennytm,Thanks for your review. |
ti-srebot
approved these changes
Jul 9, 2020
Contributor
|
@overvenus,Thanks for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry-pick #402 and #396
Release Note