Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

*: add version check before start (#311)#335

Merged
overvenus merged 1 commit intopingcap:release-3.1from
3pointer:release-3.1
Jun 5, 2020
Merged

*: add version check before start (#311)#335
overvenus merged 1 commit intopingcap:release-3.1from
3pointer:release-3.1

Conversation

@3pointer
Copy link
Collaborator

@3pointer 3pointer commented Jun 5, 2020

cherry-pick #311 to release 3.1

What problem does this PR solve?

Resolve #301

What is changed and how it works?

Add cluster version check when br start

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • Feature: Add version check at beginning in order to avoid version mismatch.

@3pointer @kennytm @overvenus
*: add version check before start (pingcap#311)
44aa39a 
* add version check

* Update pkg/utils/version.go

Co-authored-by: kennytm <kennytm@gmail.com>

* fix test

* add flag to control check

* address comment

* fix ci

* remove DS_Store

Co-authored-by: kennytm <kennytm@gmail.com>
Co-authored-by: Neil Shen <overvenus@gmail.com>
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #335 into release-3.1 will increase coverage by 0.21%.
The diff coverage is 76.28%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.1     #335      +/-   ##
===============================================
+ Coverage        70.81%   71.02%   +0.21%     
===============================================
  Files               48       48              
  Lines             5040     5081      +41     
===============================================
+ Hits              3569     3609      +40     
+ Misses             991      987       -4     
- Partials           480      485       +5
Impacted Files Coverage Δ
pkg/task/restore.go 54.80% <57.14%> (ø)
pkg/task/common.go 63.30% <66.66%> (+0.15%) ⬆️
pkg/conn/conn.go 78.73% <80.00%> (-0.44%) ⬇️
pkg/utils/version.go 88.88% <80.64%> (-11.12%) ⬇️
pkg/utils/math.go 87.50% <87.50%> (ø)
pkg/restore/import.go 70.99% <100.00%> (ø)
pkg/task/backup.go 60.99% <100.00%> (ø)
pkg/task/backup_raw.go 55.88% <100.00%> (ø)
pkg/task/restore_raw.go 58.73% <100.00%> (ø)
pkg/mock/mock_cluster.go 72.91% <0.00%> (-2.09%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b342213...44aa39a. Read the comment docs.

kennytm
kennytm reviewed Jun 5, 2020
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGTM1 label Jun 5, 2020
@overvenus overvenus merged commit 1639c24 into pingcap:release-3.1 Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

2 more reviewers

@kennytm kennytm kennytm left review comments

@overvenus overvenus overvenus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/LGT1 LGTM1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@3pointer @kennytm @overvenus