Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[cherry-pick] br: less split during restoring(tidb#27240)#1432

Merged
ti-chi-bot merged 2 commits intopingcap:release-4.0from
YuJuncen:4.0-cherry-pick-27240
Sep 6, 2021
Merged

[cherry-pick] br: less split during restoring(tidb#27240)#1432
ti-chi-bot merged 2 commits intopingcap:release-4.0from
YuJuncen:4.0-cherry-pick-27240

Conversation

@YuJuncen
Copy link
Collaborator

@YuJuncen YuJuncen commented Sep 1, 2021 •
edited
Loading

cherry-picking tidb#27240

===

Port of #1377

What problem does this PR solve?

Partially fix #1374

What is changed and how it works?

before：
--|-------t1 data-------|-----|---t2 data-------|
after: 
----------t1 data-------|---------t2 data-------|

Legends:
'|' the split point
'-' the key space

Also, downloadSST would find rewrite rules by file instead of region start key for now.

Check List

Tests

image

Release note

BR would split less regions to reduce the number of empty region after restoration.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 1, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from 3pointer and glorv September 1, 2021 07:58
@sre-bot
Copy link
Contributor

sre-bot commented Sep 1, 2021

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Sep 1, 2021
@YuJuncen
Copy link
Collaborator Author

YuJuncen commented Sep 1, 2021

BR:Backup:ErrBackupNoLeader]backup no leader" 🤔

/run-integration-test

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Sep 1, 2021
@glorv
Copy link
Collaborator

glorv commented Sep 1, 2021

/run-check_release_note

@kennytm
Copy link
Collaborator

kennytm commented Sep 2, 2021

/rebuild

@YuJuncen
Copy link
Collaborator Author

YuJuncen commented Sep 6, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f8cc37c

@ti-chi-bot ti-chi-bot merged commit 0391331 into pingcap:release-4.0 Sep 6, 2021
@zhouqiang-cl zhouqiang-cl added this to the v4.0.15 milestone Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@3pointer 3pointer Awaiting requested review from 3pointer

2 more reviewers

@kennytm kennytm kennytm approved these changes

@glorv glorv glorv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-pick-approved size/L status/can-merge status/LGT2 LGTM2 type/4.0-cherry-pick

Projects

None yet

Milestone

v4.0.15

Development

Successfully merging this pull request may close these issues.

6 participants

@YuJuncen @ti-chi-bot @sre-bot @glorv @kennytm @zhouqiang-cl