Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[cherry-pick] skip rebase auto id(#27199)#1424

Merged
ti-chi-bot merged 4 commits intopingcap:release-4.0from
YuJuncen:4.0-cherry-pick-27199
Sep 8, 2021
Merged

[cherry-pick] skip rebase auto id(#27199)#1424
ti-chi-bot merged 4 commits intopingcap:release-4.0from
YuJuncen:4.0-cherry-pick-27199

Conversation

@YuJuncen
Copy link
Collaborator

@YuJuncen YuJuncen commented Aug 31, 2021 •
edited by kennytm
Loading

cherry-picking pingcap/tidb#27199

===

What problem does this PR solve?

Speed up create tables via omit a DDL job.

Problem Summary:

What is changed and how it works?

What's Changed: Remove all DDLs of rebasing autos.

How it Works: When creating table with CreateTableWithInfo, TiDB has rebased the auto ids via the table info:

https://github.com/pingcap/tidb/blob/a9cba7c8e8b6da512609863b56ee7265c06c50dc/ddl/ddl_api.go#L1924-L1937

It's no meaning for rebasing the auto ids again.

Check List

Tests

  • Integration test (at br_views_and_sequences)

Release note 

Merged the rebase auto id operation into create table.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 31, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from 3pointer and kennytm August 31, 2021 09:44
@sre-bot
Copy link
Contributor

sre-bot commented Aug 31, 2021

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@YuJuncen YuJuncen changed the title [cherry-pick] null(#27199) [cherry-pick] skip rebase auto id(#27199) Aug 31, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Sep 1, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Sep 1, 2021
@YuJuncen
Copy link
Collaborator Author

YuJuncen commented Sep 6, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: ad52ce8

@ti-chi-bot ti-chi-bot merged commit 94ae77f into pingcap:release-4.0 Sep 8, 2021
@zhouqiang-cl zhouqiang-cl added this to the v4.0.15 milestone Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@3pointer 3pointer Awaiting requested review from 3pointer

2 more reviewers

@kennytm kennytm kennytm approved these changes

@glorv glorv glorv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-pick-approved size/M status/can-merge status/LGT2 LGTM2 type/4.0-cherry-pick

Projects

None yet

Milestone

v4.0.15

Development

Successfully merging this pull request may close these issues.

6 participants

@YuJuncen @ti-chi-bot @sre-bot @kennytm @glorv @zhouqiang-cl