Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

flag: hidden online flag#136

Merged
3pointer merged 1 commit intomasterfrom
hidden_flag
Jan 6, 2020
Merged

flag: hidden online flag#136
3pointer merged 1 commit intomasterfrom
hidden_flag

Conversation

@3pointer
Copy link
Collaborator

@3pointer 3pointer commented Jan 6, 2020

#135 is not working after I test

@3pointer 3pointer requested review from kennytm and overvenus January 6, 2020 07:49
@3pointer 3pointer added the WIP label Jan 6, 2020
@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #136 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   73.01%   73.01%           
=======================================
  Files          33       33           
  Lines        3235     3235           
=======================================
  Hits         2362     2362           
  Misses        584      584           
  Partials      289      289
Impacted Files Coverage Δ
cmd/restore.go 64.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4246b1...a0e812d. Read the comment docs.

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGTM1 label Jan 6, 2020
@3pointer 3pointer merged commit 4a9dfe6 into master Jan 6, 2020
@overvenus overvenus deleted the hidden_flag branch January 15, 2020 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants