This repository was archived by the owner on Jul 24, 2024. It is now read-only.
GCS: support --send-credentials-to-tikv and get credentials from GKE or GCE#115
Merged
overvenus merged 9 commits intopingcap:masterfrom Dec 17, 2019
Merged
GCS: support --send-credentials-to-tikv and get credentials from GKE or GCE#115overvenus merged 9 commits intopingcap:masterfrom
overvenus merged 9 commits intopingcap:masterfrom
Conversation
Member
|
/run-integration-tests |
Member
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 71.27% 71.54% +0.26%
==========================================
Files 31 31
Lines 3307 3029 -278
==========================================
- Hits 2357 2167 -190
+ Misses 648 575 -73
+ Partials 302 287 -15
Continue to review full report at Codecov.
|
overvenus
reviewed
Dec 16, 2019
Member
overvenus
left a comment
There was a problem hiding this comment.
Could you add some unit tests to improve coverage?
Contributor
|
LGTM |
Contributor
Author
Ok, I'll try. |
Member
|
Could you fix conflicts? |
Contributor
Author
|
/run-integration-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #106