open with directio at best effort#274
Merged
coocood merged 1 commit intopingcap:masterfrom Dec 29, 2022
Merged
Conversation
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
3c30a2f to
5d1e9e3
Compare
coocood
approved these changes
Dec 29, 2022
4 tasks
This was referenced Dec 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YangKeao yangkeao@chunibyo.icu
If the file system doesn't support directio, just let it go without O_DIRECT. The most common case where direct io is not supported is the tmpfs, and it brings some pain for test.