Skip to content

Add symfony/doctrine-messenger dependency to fix Symfony 5.3 compatibility issues#9296

Merged
brusch merged 2 commits into10.0from
symfony-messenger
Jun 2, 2021
Merged

Add symfony/doctrine-messenger dependency to fix Symfony 5.3 compatibility issues#9296
brusch merged 2 commits into10.0from
symfony-messenger

Conversation

@brusch
Copy link
Copy Markdown
Member

@brusch brusch commented Jun 1, 2021

No description provided.

@brusch brusch added the Bug label Jun 1, 2021
@brusch brusch added this to the 10.0.2 milestone Jun 1, 2021
@brusch brusch self-assigned this Jun 1, 2021
@brusch brusch closed this Jun 2, 2021
@brusch brusch deleted the symfony-messenger branch June 2, 2021 07:13
@brusch
Copy link
Copy Markdown
Member Author

brusch commented Jun 2, 2021

Seems to be obsolete.

@brusch brusch restored the symfony-messenger branch June 2, 2021 09:20
@brusch brusch reopened this Jun 2, 2021
@brusch brusch merged commit 5e873d3 into 10.0 Jun 2, 2021
@brusch brusch deleted the symfony-messenger branch June 2, 2021 09:31
@brusch
Copy link
Copy Markdown
Member Author

brusch commented Jun 2, 2021

Sometimes it still appears, no idea why, but adding this package fixes it, so I guess it doesn't hurt.

@jdreesen
Copy link
Copy Markdown
Contributor

jdreesen commented Jun 2, 2021

What appears? Why is this necessary?

@brusch
Copy link
Copy Markdown
Member Author

brusch commented Jun 2, 2021

This happens when building the container:

  RuntimeException {#6618
    #message: "The autoloader expected class "Symfony\Component\Messenger\Transport\Doctrine\DoctrineTransportFactory" to be defined in file "/home/demos/build/opensource-master/source-master/vendor/compose
  r/../symfony/symfony/src/Symfony/Component/Messenger/Transport/Doctrine/DoctrineTransportFactory.php". The file was found but the class was not in it, the class name or namespace probably has a typo."
    #code: 0
    #file: "./vendor/symfony/symfony/src/Symfony/Component/ErrorHandler/DebugClassLoader.php"
    #line: 401
    trace: {
      ./vendor/symfony/symfony/src/Symfony/Component/ErrorHandler/DebugClassLoader.php:401 { …}
      ./vendor/symfony/symfony/src/Symfony/Component/ErrorHandler/DebugClassLoader.php:358 { …}
      Symfony\Component\ErrorHandler\DebugClassLoader->loadClass() {}
      ./vendor/doctrine/doctrine-bundle/DependencyInjection/DoctrineExtension.php:995 { …}
      ./vendor/doctrine/doctrine-bundle/DependencyInjection/DoctrineExtension.php:79 { …}
      ./vendor/symfony/symfony/src/Symfony/Component/DependencyInjection/Compiler/MergeExtensionConfigurationPass.php:76 { …}
      ./vendor/symfony/symfony/src/Symfony/Component/HttpKernel/DependencyInjection/MergeExtensionConfigurationPass.php:39 { …}
      ./vendor/symfony/symfony/src/Symfony/Component/DependencyInjection/Compiler/Compiler.php:91 { …}
      ./vendor/symfony/symfony/src/Symfony/Component/DependencyInjection/ContainerBuilder.php:749 { …}
      ./vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php:545 { …}
      ./vendor/pimcore/pimcore/lib/Kernel.php:223 { …}
      ./vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php:786 { …}
      ./vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php:125 { …}
      ./vendor/pimcore/pimcore/lib/Kernel.php:202 { …}
      ./vendor/pimcore/pimcore/lib/Bootstrap.php:256 { …}
      ./vendor/pimcore/pimcore/lib/Bootstrap.php:60 { …}
      ./bin/console:44 {
        › /** @var \Pimcore\Kernel $kernel */
        › $kernel = \Pimcore\Bootstrap::startupCli();
        › $application = new \Pimcore\Console\Application($kernel);
      }
    }
  }

@brusch
Copy link
Copy Markdown
Member Author

brusch commented Jun 2, 2021

Ok, I've found the reason, dist is different from source for symfony/symfony.
So actually https://github.com/symfony/symfony/archive/refs/tags/v5.3.0.zip is different from what you see here https://github.com/symfony/symfony/tree/v5.3.0
Maybe @fabpot can have a look at this.

brusch added a commit that referenced this pull request Jun 2, 2021
brusch added a commit that referenced this pull request Jun 2, 2021
@brusch brusch removed this from the 10.0.2 milestone Jun 2, 2021
@brusch brusch removed the Bug label Jun 2, 2021
@brusch brusch removed their assignment Jun 2, 2021
@fabpot
Copy link
Copy Markdown

fabpot commented Jun 2, 2021

Short answer: you should never use the symfony/symfony package. Since a long time now, individual components should be used instead, we "only" keep symfony/symfony as a mono-repo where development happens (and for BC reasons, but we might remove the package from Packagist at some point).

@brusch
Copy link
Copy Markdown
Member Author

brusch commented Jun 2, 2021

Ok, I see.
Just for redcord, it's because of: https://github.com/symfony/symfony/blob/5.4/.gitattributes#L4

@brusch brusch restored the symfony-messenger branch June 2, 2021 10:51
@brusch brusch deleted the symfony-messenger branch June 2, 2021 10:52
brusch added a commit that referenced this pull request Jun 2, 2021
…ony 5.3 compatibility issues (#9296)""

This reverts commit bd5323f.
@brusch brusch added this to the 10.0.2 milestone Jun 2, 2021
@brusch brusch added the Bug label Jun 2, 2021
@brusch brusch self-assigned this Jun 2, 2021
brusch added a commit that referenced this pull request Jun 2, 2021
…ony 5.3 compatibility issues (#9296)""

This reverts commit bd5323f.
@brusch
Copy link
Copy Markdown
Member Author

brusch commented Jun 2, 2021

So we need that fix for now, until #9312 is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants