[Security]: Dependency Dao - Refactor SQL queries to use parameter binding#18991
Merged
[Security]: Dependency Dao - Refactor SQL queries to use parameter binding#18991
Conversation
Review Checklist
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors SQL queries in the Dependency DAO to use parameter binding instead of string concatenation, addressing SQL injection security vulnerabilities. This is part of a broader security improvement initiative (related to https://github.com/pimcore/ee-pimcore/pull/743).
Changes:
- Replaced string concatenation with named parameter placeholders (:sourceType, :sourceId, :targetType, :targetId, :value) in SQL queries
- Added parameter and type arrays for proper parameter binding with Doctrine DBAL
- Cleaned up unnecessary conditional return logic
- Fixed minor formatting inconsistencies (spacing around operators, AS keyword capitalization)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Related https://github.com/pimcore/ee-pimcore/pull/743
Additional info