[Bug, EC] PEES-923: type error in getDataForListfolderGrid#18977
Merged
[Bug, EC] PEES-923: type error in getDataForListfolderGrid#18977
Conversation
Review Checklist
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a strict-types TypeError in Pimcore’s asset metadata handling when rendering listfolder grid values by ensuring numeric values are passed to Asset::getById() as an int.
Changes:
- Cast listfolder-grid numeric metadata values to
intbefore calling\Pimcore\Model\Asset::getById().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves https://github.com/pimcore/service-operations/issues/326
Additional info