Skip to content

Fix hotspot data index#18948

Merged
robertSt7 merged 2 commits into12.3from
fix-hotspotData-index
Jan 27, 2026
Merged

Fix hotspot data index#18948
robertSt7 merged 2 commits into12.3from
fix-hotspotData-index

Conversation

@robertSt7
Copy link
Copy Markdown
Contributor

follow-up #18855

@robertSt7 robertSt7 added this to the 12.3.2 milestone Jan 27, 2026
Copilot AI review requested due to automatic review settings January 27, 2026 16:49
@robertSt7 robertSt7 added the Bug label Jan 27, 2026
@github-actions
Copy link
Copy Markdown

Review Checklist

  • Target branch (12.3 for bug fixes, others 12.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an array index out of bounds issue when loading image gallery data where images exist but no hotspot data is present. This is a follow-up to PR #18855, which changed how empty hotspot data is stored in the database (from serialized empty array to null).

Changes:

  • Added null coalescing operator to handle missing hotspot data during image gallery deserialization

@robertSt7 robertSt7 merged commit 4ae3738 into 12.3 Jan 27, 2026
19 checks passed
@robertSt7 robertSt7 deleted the fix-hotspotData-index branch January 27, 2026 16:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants