Skip to content

fix: Skip http_error_log cleanup migration if table is missing#18922

Merged
kingjia90 merged 1 commit intopimcore:11.5from
astehlik:fix-http-error-log-migration-11.5
Jan 16, 2026
Merged

fix: Skip http_error_log cleanup migration if table is missing#18922
kingjia90 merged 1 commit intopimcore:11.5from
astehlik:fix-http-error-log-migration-11.5

Conversation

@astehlik
Copy link
Copy Markdown
Contributor

@astehlik astehlik commented Jan 15, 2026

Changes in this pull request

When the PimcoreSeoBundle is not enabled the table http_error_log does not exist and the cleanup migration fails. To prevent this, the migration is skipped if the table does not exist.

Additional info

Issue was introduced by PR #18918

When the PimcoreSeoBundle is not enabled the table does not
exist and the migration fails. To prevent this, the migration
is skipped if the http_error_log does not exist.
@github-actions
Copy link
Copy Markdown

Review Checklist

  • Target branch (11.5 for bug fixes, others 12.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 merged commit 2ee6fb5 into pimcore:11.5 Jan 16, 2026
18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
@kingjia90 kingjia90 self-assigned this Jan 16, 2026
@kingjia90
Copy link
Copy Markdown
Contributor

Thank you for the PR!
Hotfixes released 11.5.14.1 and 12.3.1.1, wish you a nice weekend!

@kingjia90 kingjia90 added this to the 11.5.14.1 milestone Jan 16, 2026
@astehlik astehlik deleted the fix-http-error-log-migration-11.5 branch January 16, 2026 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants