Skip to content

[Bug]: Fix Static Route permission#18893

Merged
kingjia90 merged 1 commit into11.5from
fix-static-routes-permission
Dec 17, 2025
Merged

[Bug]: Fix Static Route permission#18893
kingjia90 merged 1 commit into11.5from
fix-static-routes-permission

Conversation

@kingjia90
Copy link
Copy Markdown
Contributor

@kingjia90 kingjia90 commented Dec 17, 2025

Changes in this pull request

Resolves #

Additional info

Looking at

if (user.isAllowed("routes") && perspectiveCfg.inToolbar("settings.routes")) {
both read/listing and edit should be forbidden when not having the permission

@github-actions
Copy link
Copy Markdown

Review Checklist

  • Target branch (11.5 for bug fixes, others 12.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 self-assigned this Dec 17, 2025
@kingjia90 kingjia90 merged commit 89b4f42 into 11.5 Dec 17, 2025
10 of 20 checks passed
@kingjia90 kingjia90 deleted the fix-static-routes-permission branch December 17, 2025 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant