Skip to content

fix: dont use symfony 7.4#18866

Merged
herbertroth merged 12 commits into12.2from
fix-symfony74-serializer
Dec 2, 2025
Merged

fix: dont use symfony 7.4#18866
herbertroth merged 12 commits into12.2from
fix-symfony74-serializer

Conversation

@herbertroth
Copy link
Copy Markdown
Member

@herbertroth herbertroth commented Dec 1, 2025 •
edited
Loading

This PR restricts Symfony component versions to prevent compatibility issues with Symfony 7.4+.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 1, 2025

Review Checklist

  • Target branch (11.5 for bug fixes, others 12.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@jdreesen
Copy link
Copy Markdown
Contributor

jdreesen commented Dec 1, 2025

This pull request makes a minor update to the project's dependencies in composer.json. The only change is the addition of a new requirement for the symfony/serializer package with a version constraint greater than 7.3.

Dependency update:
Added symfony/serializer with version constraint >7.3 to the list of required packages in composer.json.

This is not true! It was added to the conflicts section!

@herbertroth herbertroth changed the title fix: add symfony/serializer dependency to composer.json fix: add symfony/* >7.3 conflicts to composer.json Dec 1, 2025
@herbertroth herbertroth changed the title fix: add symfony/* >7.3 conflicts to composer.json fix: dont use symfony 7.4 Dec 1, 2025
@jdreesen
Copy link
Copy Markdown
Contributor

jdreesen commented Dec 1, 2025

dont use symfony 7.4

Why not? There should be no breaking changes 🤔

@fashxp fashxp mentioned this pull request Dec 2, 2025
Closed
@fashxp
Copy link
Copy Markdown
Member

fashxp commented Dec 2, 2025

dont use symfony 7.4

Why not? There should be no breaking changes 🤔

should not, but reality looks different right now 😞

@herbertroth
Copy link
Copy Markdown
Member Author

herbertroth commented Dec 2, 2025 •
edited
Loading

dont use symfony 7.4

Why not? There should be no breaking changes 🤔

Symfony 7.4 has multiple BC breaks:

AttributeLoader constructor changed - no longer accepts Doctrine Annotations Reader
DumpDataCollector::serialize() is now final - breaks lazy proxy generation
...

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@herbertroth herbertroth merged commit 7decde3 into 12.2 Dec 2, 2025
13 checks passed
@herbertroth herbertroth deleted the fix-symfony74-serializer branch December 2, 2025 08:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2025
@herbertroth herbertroth added this to the 12.2.3 milestone Dec 2, 2025
@herbertroth
Copy link
Copy Markdown
Member Author

herbertroth commented Dec 2, 2025

resolves pimcore/skeleton#247

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

12.2.3

Development

Successfully merging this pull request may close these issues.

3 participants

@herbertroth @jdreesen @fashxp