Skip to content

[Task][Tests]: Fix DomCrawler differences from PHP 8.4 HTML5 renderer#18865

Merged
kingjia90 merged 3 commits into12.xfrom
fix-tests
Dec 1, 2025
Merged

[Task][Tests]: Fix DomCrawler differences from PHP 8.4 HTML5 renderer#18865
kingjia90 merged 3 commits into12.xfrom
fix-tests

Conversation

@kingjia90
Copy link
Copy Markdown
Contributor

@kingjia90 kingjia90 commented Dec 1, 2025 •
edited
Loading

Changes in this pull request

Resolves #

Additional info

so new DomCrawler has some magic that adds head tags when body is set, so adding it to the hardcoded html string to be used for assertion

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 1, 2025

Review Checklist

  • Target branch (11.5 for bug fixes, others 12.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 changed the title [Task][': Fix DomCrawler differnces from php html5 renderer [Task][Tests]: Fix DomCrawler differnces from php html5 renderer Dec 1, 2025
@kingjia90 kingjia90 changed the title [Task][Tests]: Fix DomCrawler differnces from php html5 renderer [Task][Tests]: Fix DomCrawler differnces from PHP 8.4 HTML5 renderer Dec 1, 2025
@kingjia90 kingjia90 changed the title [Task][Tests]: Fix DomCrawler differnces from PHP 8.4 HTML5 renderer [Task][Tests]: Fix DomCrawler differences from PHP 8.4 HTML5 renderer Dec 1, 2025
@kingjia90 kingjia90 added this to the 12.3.0 milestone Dec 1, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kingjia90 kingjia90 self-assigned this Dec 1, 2025
@kingjia90 kingjia90 merged commit 668fe0a into 12.x Dec 1, 2025
13 checks passed
@kingjia90 kingjia90 deleted the fix-tests branch December 1, 2025 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@kingjia90 kingjia90

Labels

Pimcore:ToDo Task

Projects

None yet

Milestone

12.3.0

Development

Successfully merging this pull request may close these issues.

1 participant

@kingjia90