[Task]: Deprecate unused method and exception in BundleLocator namespace#18861
Merged
fashxp merged 1 commit intopimcore:12.xfrom Dec 9, 2025
Merged
Conversation
Review Checklist
|
Contributor
Author
|
/cc @fashxp |
|
Member
|
failing tests can't be related. |
Member
|
thx very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of #18858 I had a closer look at the
Pimcore\HttpKernel\BundleLocator.It seems like
\Pimcore\HttpKernel\BundleLocator\InvalidArgumentExceptionis not used anywhere, so I deprecated it.Also
\Pimcore\HttpKernel\BundleLocator\BundleLocatorInterface::getBundlePath()is not used anywhere, so I deprecated it too.The only place where
Pimcore\HttpKernel\BundleLocator\BundleLocatorInterfaceis actually used seems to be the\Pimcore\Document\Editable\EditableHandlerand it already usesBundleLocatorInterface::getBundle()->getPath().