Add shareBetweenFolders column to gridconfigs#18817
Merged
Conversation
Review Checklist
|
Contributor
|
LGTM, just needs to be in a minor release as an improvement due to migration, so not considering it strictly as a bug but as a missing feature |
kingjia90
reviewed
Nov 12, 2025
kingjia90
reviewed
Nov 12, 2025
Contributor
kingjia90
left a comment
There was a problem hiding this comment.
LGTM code-wise overall, just some index, the indentation and spacing in the install.sql.
We would need upgrade notes if we go forward as considering this as an improvement
Co-authored-by: JiaJia Ji <kingjia90@gmail.com>
kingjia90
reviewed
Nov 12, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.