Skip to content

[Bug, EC] PEES-816: Fix Maintenance Mode does not work as intendend when activated via cli#18803

Merged
kingjia90 merged 2 commits into12.2from
fix-maintanenance-mode-cli
Nov 5, 2025
Merged

[Bug, EC] PEES-816: Fix Maintenance Mode does not work as intendend when activated via cli#18803
kingjia90 merged 2 commits into12.2from
fix-maintanenance-mode-cli

Conversation

@kingjia90
Copy link
Copy Markdown
Contributor

@kingjia90 kingjia90 commented Nov 5, 2025 •
edited
Loading

Changes in this pull request

Resolves https://github.com/pimcore/service-operations/issues/275

Additional info

likely caused by

pimcore/lib/Cache/Core/CoreCacheHandler.php

Lines 297 to 305 in df14e02

if ($this->isCli()) {
if (!$this->handleCli && !$force) {
$this->logger->debug(
'Not saving {key} to cache as process is running in CLI mode (pass force to override or set handleCli to true)',
['key' => $key]
);
return false;
}

@kingjia90 kingjia90 added this to the 12.2.3 milestone Nov 5, 2025
@kingjia90 kingjia90 self-assigned this Nov 5, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 5, 2025

Review Checklist

  • Target branch (11.5 for bug fixes, others 12.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kingjia90 kingjia90 merged commit 824130a into 12.2 Nov 5, 2025
13 checks passed
@kingjia90 kingjia90 deleted the fix-maintanenance-mode-cli branch November 5, 2025 10:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@kingjia90 kingjia90

Labels

Bug Pimcore:Priority

Projects

None yet

Milestone

12.2.3

Development

Successfully merging this pull request may close these issues.

1 participant

@kingjia90