Skip to content

Improve: add date folders for log files#18792

Merged
robertSt7 merged 9 commits into12.xfrom
15952-feature-use-subfolders-in-email-storage-to-prevent-a-flat-list
Nov 12, 2025
Merged

Improve: add date folders for log files#18792
robertSt7 merged 9 commits into12.xfrom
15952-feature-use-subfolders-in-email-storage-to-prevent-a-flat-list

Conversation

@robertSt7
Copy link
Copy Markdown
Contributor

@robertSt7 robertSt7 commented Oct 30, 2025

resolves #15952

@robertSt7 robertSt7 added this to the 12.3.0 milestone Oct 30, 2025
@robertSt7 robertSt7 self-assigned this Oct 30, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 30, 2025

Review Checklist

  • Target branch (11.5 for bug fixes, others 12.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

kingjia90
kingjia90 reviewed Oct 30, 2025
View reviewed changes
kingjia90
kingjia90 reviewed Oct 30, 2025
View reviewed changes
@kingjia90
Copy link
Copy Markdown
Contributor

kingjia90 commented Oct 30, 2025 •
edited
Loading

I feel it would be better if the check fileExists are always on the ones with the date aka getHtmlLogFilenameWithDate first, and only when not found, it should fallback to check the one without date (and log/warn that they need to run migration or manually fix it), by assuming that the devs already ran the migration right after upgrade and the files are almost surely in the new format.

kingjia90
kingjia90 reviewed Oct 31, 2025
View reviewed changes
kingjia90
kingjia90 reviewed Oct 31, 2025
View reviewed changes
robertSt7 and others added 2 commits October 31, 2025 11:40
@robertSt7 @kingjia90
Update models/Tool/Email/Log.php
ea24cc2 
Co-authored-by: JiaJia Ji <kingjia90@gmail.com>
@brusch
Updated docs
765e500
@robertSt7
Merge remote-tracking branch 'origin/12.x' into 15952-feature-use-sub…
971ea93 
…folders-in-email-storage-to-prevent-a-flat-list
@robertSt7
Merge remote-tracking branch 'origin/12.x' into 15952-feature-use-sub…
34ada12 
…folders-in-email-storage-to-prevent-a-flat-list
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 12, 2025

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@robertSt7 robertSt7 merged commit 48541a9 into 12.x Nov 12, 2025
14 checks passed
@robertSt7 robertSt7 deleted the 15952-feature-use-subfolders-in-email-storage-to-prevent-a-flat-list branch November 12, 2025 15:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kingjia90 kingjia90 kingjia90 left review comments

@brusch brusch brusch approved these changes

Assignees

@robertSt7 robertSt7

Labels

Improvement

Projects

None yet

Milestone

12.3.0

Development

Successfully merging this pull request may close these issues.

[Feature]: Use subfolders in email storage to prevent a flat list of 10k+ files

4 participants

@robertSt7 @kingjia90 @brusch @fashxp