Merged
Conversation
…Symfony 7.3 support
…s to support Symfony 7.2
Review Checklist
|
jdreesen
reviewed
Oct 14, 2025
…d compatibility with Symfony 6
…rait in migration class
…nce checks and catch broader exceptions
…and improve readability
…ed services and documentation
…e container; recommend injecting Twig\Environment directly
… ParameterBag instances; update controllers to utilize the new helper methods for integer and boolean retrieval.
…rrectly, ensuring default value logic is preserved.
…ameterBag methods; introduce ParameterBagHelper for safe parameter retrieval.
- Updated the Controller documentation to improve readability and formatting. - Enhanced the Custom Routes documentation with clearer explanations and examples. - Revised the Renderlet documentation for better structure and clarity. - Improved the PHP API documentation for Objects, ensuring consistent formatting and clearer examples. - Refined the Best Practice guides for integrating commerce data and using tags for filtering, enhancing clarity and organization.
jdreesen
reviewed
Oct 20, 2025
- Updated various sections in the Custom Routes documentation to enhance readability and fix formatting issues. - Improved the Renderlet documentation by clarifying configuration options and methods. - Cleaned up the Working with PHP API documentation, ensuring consistent formatting and removing unnecessary whitespace. - Enhanced the Integrating Commerce Data with Content documentation by refining code examples and improving structure. - Revised the Open By External ID documentation for better clarity and consistency in code snippets. - Improved the Using Tags for Filtering documentation by refining code examples and ensuring consistent formatting.
kingjia90
reviewed
Oct 21, 2025
…d int and bool values in dev/staging environments
…d int and bool values in dev/staging environments
…taging environments
…Bool methods to include caller information.
jdreesen
reviewed
Oct 21, 2025
…lize logic in triggerDeprecation method
…eprecation warning logic and ensure proper handling in non-debug environments
kingjia90
reviewed
Oct 22, 2025
bundles/CoreBundle/src/DependencyInjection/Compiler/ContainerAwarePass.php
Outdated
Show resolved
Hide resolved
…pdate upgrade notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important changes to improve Symfony 7 compatibility, deprecate legacy templating components, and refactor service container injection for better maintainability. The most impactful updates are the deprecation of the Symfony Templating Component in favor of Twig, the introduction of a new mechanism for injecting the service container into legacy services, and various configuration and codebase cleanups.
Symfony 7 compatibility and templating deprecation
Deprecated the use of
Symfony\Component\Templating\EngineInterfaceand related services in favor of usingTwig\Environmentdirectly. This affects multiple classes and services, and will be removed in version 13.0. Upgrade notes have been added to guide developers through the migration. (UPGRADE.md,bundles/CoreBundle/config/templating.yaml) [1] [2]Marked
pimcore.templating.engine.delegatingandSymfony\Component\Templating\EngineInterfaceservices as deprecated in configuration, with clear messages for developers. (bundles/CoreBundle/config/templating.yaml)Service container injection refactor
AreabrickPassand introduced a newContainerAwarePasscompiler pass that automatically injects the service container into all services implementing the newContainerAwareInterface. This provides backward compatibility for Symfony 6 code while preparing for Symfony 7. (bundles/CoreBundle/src/DependencyInjection/Compiler/AreabrickPass.php,bundles/CoreBundle/src/DependencyInjection/Compiler/ContainerAwarePass.php,bundles/CoreBundle/src/DependencyInjection/ContainerAwareInterface.php,bundles/CoreBundle/src/DependencyInjection/ContainerAwareTrait.php) [1] [2] [3] [4] [5] [6]Configuration and codebase cleanup
bundles/CoreBundle/config/documents.yaml,bundles/CoreBundle/config/services_workflow.yaml,bundles/CoreBundle/config/templating.yaml) [1] [2] [3] [4] [5]Routing loader update
bundles/CoreBundle/src/DependencyInjection/Compiler/RoutingLoaderPass.php)Miscellaneous improvements
ParameterBagHelper::getInt()for more robust parameter extraction in several places. (bundles/ApplicationLoggerBundle/src/Controller/LogController.php,bundles/CoreBundle/src/Controller/PublicServicesController.php,bundles/CoreBundle/src/EventListener/Frontend/ElementListener.php) [1] [2] [3] [4] [5] [6]