Skip to content

[Improvement] Better error message for symfony-config write target in production migrations#18760

Merged
fashxp merged 2 commits intopimcore:12.xfrom
creativehubspace:12.x
Oct 13, 2025
Merged

[Improvement] Better error message for symfony-config write target in production migrations#18760
fashxp merged 2 commits intopimcore:12.xfrom
creativehubspace:12.x

Conversation

@creativehubspace
Copy link
Copy Markdown
Contributor

Fixes #17388

Changes

Improved the error output message in class definition migrations to better explain the symfony-config write target limitation when running in production mode.

What was changed

  • Enhanced error message to clearly indicate that symfony-config write target makes configs read-only in non-debug mode
  • Added line breaks for better readability
  • Provided actionable solutions (enable debug mode, switch to alternate config-storage, or set environment variable)

Why

The previous error message didn't clearly explain why definitions couldn't be written when using symfony-config in production, leading to confusion for developers running migrations.

…roduction

Enhanced the error output in class definition migration to better explain
the symfony-config write target limitation when running in production mode.
The message now clearly indicates that configs are read-only in non-debug
mode and provides actionable solutions for resolving the issue.

Fixes pimcore#17388
@github-actions
Copy link
Copy Markdown

Review Checklist

  • Target branch (11.5 for bug fixes, others 12.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 10, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@creativehubspace
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sonarqubecloud
Copy link
Copy Markdown

@fashxp
Copy link
Copy Markdown
Member

fashxp commented Oct 13, 2025

thx very much!

@fashxp fashxp merged commit a47c037 into pimcore:12.x Oct 13, 2025
13 of 19 checks passed
@fashxp fashxp added this to the 12.3.0 milestone Oct 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: "classes-rebuild -d" fails on deployment

2 participants