Skip to content

PhpStan Version Upgrade September#18685

Merged
kingjia90 merged 7 commits into12.1from
phpstan-sept
Sep 17, 2025
Merged

PhpStan Version Upgrade September#18685
kingjia90 merged 7 commits into12.1from
phpstan-sept

Conversation

@kingjia90
Copy link
Copy Markdown
Contributor

@kingjia90 kingjia90 commented Sep 16, 2025

Changes in this pull request

Resolves #18660

Additional info

@kingjia90 kingjia90 added this to the 12.1.5 milestone Sep 16, 2025
@kingjia90 kingjia90 self-assigned this Sep 16, 2025
@github-actions
Copy link
Copy Markdown

Review Checklist

  • Target branch (11.5 for bug fixes, others 12.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90
Copy link
Copy Markdown
Contributor Author

kingjia90 commented Sep 17, 2025

https://github.com/pimcore/pimcore/actions/runs/17794209174/job/50578091535

Sticking to 2.1.26, 2.1.27 seems there might be a regression by phpstan/phpstan-src@1064566 of

* @property Model\Asset\Document|null $asset

@sonarqubecloud
Copy link
Copy Markdown

@kingjia90 kingjia90 merged commit 06c92ae into 12.1 Sep 17, 2025
13 checks passed
@kingjia90 kingjia90 deleted the phpstan-sept branch September 17, 2025 10:43
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants