Add support for preGetData on data types within block elements#18139
Merged
mcop1 merged 2 commits intopimcore:12.xfrom Sep 12, 2025
Merged
Add support for preGetData on data types within block elements#18139mcop1 merged 2 commits intopimcore:12.xfrom
mcop1 merged 2 commits intopimcore:12.xfrom
Conversation
Review Checklist
|
|
Contributor
|
Thank you! |
mcop1
approved these changes
Aug 19, 2025
mcop1
reviewed
Aug 19, 2025
Contributor
mcop1
left a comment
There was a problem hiding this comment.
Code looks good to me, thanks.
But I think it would be better to move the change to a minor release, since we consider it to be an improvement. Could you please rebase the branch to 12.2? If you could also add something to the release notes it would be highly appreciated.
mcop1
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #16814