[Task]: Remove extracted NewsletterBundle from Core repository#14902
Merged
[Task]: Remove extracted NewsletterBundle from Core repository#14902
Conversation
Review Checklist
|
kingjia90
requested changes
Apr 12, 2023
Contributor
There was a problem hiding this comment.
LGTM Removal is fine, just misses some useful info that could be put in this PR along the removal
- Upgrade notes that is moved to
pimcore/newsletter-bundle - a mention in https://github.com/pimcore/pimcore/blob/11.x/doc/23_Installation_and_Upgrade/07_Updating_Pimcore/12_V10_to_V11.md about the compatibility-bridge necessity (pimcore/compatibility-bridge-v10#5)
Contributor
Author
[Newsletter] has been moved to pimcore/newsletter-bundle package. -> Upgrade notes are already there since I put them in the Extraction PR already :) |
dvesh3
reviewed
Apr 12, 2023
doc/23_Installation_and_Upgrade/07_Updating_Pimcore/12_V10_to_V11.md
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #14802
Additional info
WHAT
🤖 Generated by Copilot at f3295dd
Removed the deprecated
PimcoreNewsletterBundleand all its related files and configurations. This bundle provided a newsletter feature that was based on an outdated library and had security and performance issues.🤖 Generated by Copilot at f3295dd
HOW
🤖 Generated by Copilot at f3295dd