Skip to content

[Task]: Remove extracted Web2Print bundle from Core repository#14871

Merged
dvesh3 merged 7 commits into11.xfrom
remove_extracted_web2print_bundle
Apr 7, 2023
Merged

[Task]: Remove extracted Web2Print bundle from Core repository#14871
dvesh3 merged 7 commits into11.xfrom
remove_extracted_web2print_bundle

Conversation

@kingjia90
Copy link
Copy Markdown
Contributor

@kingjia90 kingjia90 commented Apr 6, 2023 •
edited
Loading

Changes in this pull request

Resolves #12525

See https://github.com/pimcore/web-to-print-bundle

@kingjia90 kingjia90 added the Task label Apr 6, 2023
@kingjia90 kingjia90 added this to the 11.0.0 milestone Apr 6, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2023 •
edited by kingjia90
Loading

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

mattamon
mattamon reviewed Apr 6, 2023
View reviewed changes
mattamon
mattamon suggested changes Apr 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks fine to me :)

@kingjia90 @mattamon
task: apply changelog suggestion
0557d72 
Co-authored-by: Matthias Schuhmayer <38959016+mattamon@users.noreply.github.com>
@mattamon
Copy link
Copy Markdown
Contributor

mattamon commented Apr 6, 2023

Now we should resolve the conflicts first :)

kingjia90 added 2 commits April 6, 2023 13:50
@kingjia90
Merge remote-tracking branch 'origin/11.x' into remove_extracted_web2…
b0b97a2 
…print_bundle

# Conflicts:
#	bundles/WebToPrintBundle/src/DependencyInjection/Configuration.php
#	bundles/WebToPrintBundle/src/DependencyInjection/PimcoreWebToPrintExtension.php
@kingjia90
Merge remote-tracking branch 'origin/11.x' into remove_extracted_web2…
229d58a 
…print_bundle

# Conflicts:
#	bundles/WebToPrintBundle/src/PimcoreWebToPrintBundle.php
#	bundles/WebToPrintBundle/src/Processor.php
#	bundles/WebToPrintBundle/src/Processor/PdfReactor.php
#	bundles/WebToPrintBundle/src/Twig/Extension/PrintCatalogExtension.php
@kingjia90

This comment was marked as outdated.

Sign in to view
@dvesh3 dvesh3 merged commit 0cb5e17 into 11.x Apr 7, 2023
@dvesh3 dvesh3 deleted the remove_extracted_web2print_bundle branch April 7, 2023 07:08
@dvesh3 dvesh3 mentioned this pull request Apr 7, 2023
Merged
@kingjia90 kingjia90 mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mattamon mattamon mattamon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattamon mattamon

Labels

Task

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

[Task] Move Web-to-print to repository pimcore/web-to-print-bundle

3 participants

@kingjia90 @mattamon @dvesh3