[Task] Move sitemaps and redirects to SEO Bundle#14348
Conversation
Review Checklist
|
There was a problem hiding this comment.
The redirects table should also be installed in the Bundle Installer and not from the Installerbundle
The redirects do not open anymore in the backend.
bundles/SeoBundle/public/js/redirects.js -> You have to also change the namespaces like with the rest of the seo bundle.
bundles/SeoBundle/src/Controller/RedirectsController.php also here the names of the routes need to be changed .
Check the https://github.com/pimcore/product-management/issues/13#RefactoringTips for more info.
You also need to remove the redirect menu from the toolbar.js to the startup.js in the bundle.
If the icon is not used anywhere else you can move it to the icons.css in the bundle too.
Also the handler this.editRedirects need to be moved into the startup.js
if (user.isAllowed("redirects") && perspectiveCfg.inToolbar("extras.redirects")) {
extrasItems.push({
text: t("redirects"),
iconCls: "pimcore_nav_icon_redirects",
itemId: 'pimcore_menu_extras_redirects',
handler: this.editRedirects
});
}
bundles/SeoBundle/src/EventListener/SitemapGeneratorListener.php
Outdated
Show resolved
Hide resolved
* Move Redirect status_codes to SEOBundle. * Moved Events to SEOBundle * Hardlink doDelete * Page doDelete * URLSlag Change Moved redirect table install to SEOBundle. Moved redirect Cleanup task to SEOBundle. Rename route name. Moved menu creation to SEOBundle.
# Conflicts: # bundles/CoreBundle/src/DependencyInjection/Configuration.php # bundles/CoreBundle/src/DependencyInjection/PimcoreCoreExtension.php # bundles/SeoBundle/config/services.yaml # models/Document/Page.php
7af16c2 to
efa03e3
Compare
mattamon
left a comment
There was a problem hiding this comment.
Overall looks fine to me, just some minor changes.
Please check the https://github.com/pimcore/pimcore/blob/11.x/bundles/AdminBundle/public/js/pimcore/document/tree.js#L316, if nodes are moved we ask if redirects should be created.
In the DocumentsController are still some references to the old Redirects.
https://github.com/pimcore/pimcore/blob/11.x/bundles/AdminBundle/src/Controller/Admin/Document/DocumentController.php#L563
bundles/SeoBundle/src/EventListener/SitemapGeneratorListener.php
Outdated
Show resolved
Hide resolved
# Conflicts: # bundles/CoreBundle/src/DependencyInjection/PimcoreCoreExtension.php
mattamon
left a comment
There was a problem hiding this comment.
Looks fine for me, just a few small concerns that need to be considered.
doc/Development_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md
Outdated
Show resolved
Hide resolved
doc/Development_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md
Outdated
Show resolved
Hide resolved
dvesh3
left a comment
There was a problem hiding this comment.
Also update docs:
that these features require PimcoreSeoBundle to be enabled and installed.
doc/Development_Documentation/02_MVC/04_Routing_and_URLs/04_Redirects.md
Outdated
Show resolved
Hide resolved
doc/Development_Documentation/18_Tools_and_Features/39_Sitemaps.md
Outdated
Show resolved
Hide resolved
|
@martineiber can you please merge the latest changes and then I think we are good to merge. :) |
# Conflicts: # bundles/CoreBundle/config/pimcore/default.yaml
doc/Development_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md
Outdated
Show resolved
Hide resolved
…pgrade_Notes/README.md
doc/Development_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md
Outdated
Show resolved
Hide resolved
…pgrade_Notes/README.md


Changes in this pull request
Resolves #14260
Additional info
Follow-up PR pimcore/demo#417