Merged
Conversation
Added icons Added migration Added translation
Review Checklist
|
dvesh3
reviewed
Dec 28, 2022
bundles/CoreBundle/src/EventListener/Frontend/HardlinkCanonicalListener.php
Show resolved
Hide resolved
bundles/StaticRoutesBundle/src/Migrations/Version20221222134837.php
Outdated
Show resolved
Hide resolved
bundles/StaticRoutesBundle/src/Migrations/Version20221222134837.php
Outdated
Show resolved
Hide resolved
bundles/StaticRoutesBundle/src/Migrations/Version20221222134837.php
Outdated
Show resolved
Hide resolved
dvesh3
reviewed
Dec 28, 2022
Rename bundle from StaticRoutesBundle to PimcoreStaticRoutesBundle Adding Eventlistener for pimcore settings Moving migration to core
# Conflicts: # .github/ci/files/config/bundles.php # bundles/StaticRoutesBundle/src/Routing/Staticroute/Router.php # composer.json
Updated namespaces and routes Added upgrade notes
# Conflicts: # bundles/StaticRoutesBundle/public/js/settings.js
dvesh3
reviewed
Jan 5, 2023
bundles/CoreBundle/src/EventListener/Frontend/ElementListener.php
Outdated
Show resolved
Hide resolved
bundles/CoreBundle/src/EventListener/Frontend/HardlinkCanonicalListener.php
Outdated
Show resolved
Hide resolved
Updating migration to the correct bundle namespace
dvesh3
reviewed
Jan 10, 2023
# Conflicts: # .github/ci/files/config/bundles.php # bundles/AdminBundle/src/Controller/Admin/SettingsController.php # composer.json # doc/Development_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md
# Conflicts: # bundles/CoreBundle/translations/en.extended.json
Add the translation for routes
# Conflicts: # bundles/StaticRoutesBundle/src/Routing/Staticroute/Router.php # composer.json # lib/Routing/Element/Router.php
Remove unnecessary if conditions
# Conflicts: # .github/ci/files/config/bundles.php
dvesh3
previously requested changes
Jan 16, 2023
dvesh3
approved these changes
Jan 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #12527
Additional info
Moving static routes functionality into StaticRoutesBundle
Able to install and uninstall via Installer. Permissions are in the Bundle
Moved translations into the bundle