Conversation
Removing keybinding helpers (will be reintroduced with new event)
Review Checklist
|
Adding warning to enable bundle manually Removing unnecessary interfaces Changing route names
Reverting routes Adding bundle name to migration warning
kingjia90
requested changes
Dec 28, 2022
Contributor
kingjia90
left a comment
There was a problem hiding this comment.
Overall looks and works fine, just found some minor issues
# Conflicts: # .github/ci/files/config/bundles.php # composer.json
Added menu items Added key bindings
…sistency Moving http_error_log table to bundle and installer Adding Exceptionlistener with higher priority
brusch
requested changes
Jan 5, 2023
bundles/SeoBundle/src/Controller/Document/DocumentController.php
Outdated
Show resolved
Hide resolved
Member
|
@mattamon there are some new conflicts that need to be resolved 😊 |
# Conflicts: # bundles/SeoBundle/public/js/httpErrorLog.js # bundles/SeoBundle/public/js/robotstxt.js # bundles/SeoBundle/public/js/seopanel.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #12518
Additional info
Moving seo functionality into SeoBundle
Able to install and uninstall via Installer. Permissions are in the Bundle
User Keybindings will be added after glossary bundle is merged
Moved translations into the bundle