12517 move glossary to bundle by mattamon · Pull Request #13811 · pimcore/pimcore

mattamon · 2022-12-15T14:09:01Z

Changes in this pull request

Resolves #12517

Additional info

Moving glossary functionality into GlossaryBundle
Able to install and uninstall via Installer. Permissions are in the Bundle
User Keybindings are now configurable and can be added from anywhere via event
Menu Items are now added via Eventlistener pimcore.events.preMenuBuild.
Menus do now have a priority to figure out the sorting. Standard pimcore menus priority increases by 10 to leave enough space for additonal menu items.

Adding migration for settings store Moving DependencyInjection Configuration back to Core

github-actions · 2022-12-15T14:09:16Z

Review Checklist

Target branch (10.5 for bug fixes, others 11.x)
Tests (if it's testable code, there should be a test for it - get help)
Docs (every functionality needs to be documented, see here)
Migration incl. install.sql (e.g. if the database schema changes, ...)
Upgrade notes (deprecations, important information, migration hints, ...)
Label
Milestone

mattamon · 2022-12-15T14:19:21Z

What should we do with the documentation?
https://pimcore.com/docs/pimcore/11.0/Development_Documentation/Tools_and_Features/Glossary.html
https://github.com/pimcore/pimcore/blob/11.x/doc/Development_Documentation/18_Tools_and_Features/21_Glossary.md

Is there a way to we can sync this in the documentation after we move it?

brusch · 2022-12-15T14:36:36Z

@mattamon since the glossary bundle will stay in this repo, we keep the docs for this in place.
For bundles that will be separated out into their own repo, we move the docs as well, just as we did with other bundles (DataHub, ...)

bundles/GlossaryBundle/public/css/glossary.css

bundles/GlossaryBundle/public/js/glossary.js

bundles/GlossaryBundle/src/Controller/SettingsController.php

bundles/GlossaryBundle/src/DependencyInjection/GlossaryExtension.php

bundles/GlossaryBundle/src/Migrations/Version20221215071650.php

Adding warning to enable bundle manually Removing unnecessary interfaces Changing glossary.css to icons.css Changing route names

Reverting routes Adding bundle name to migration warning

bundles/GlossaryBundle/src/Migrations/Version20221215071650.php

dvesh3

we should update docs to notify the bundle should be enabled and installed to use the feature https://github.com/pimcore/pimcore/blob/bd8b764859c2a28be11280aab44d20f761c4cb72/doc/Development_Documentation/18_Tools_and_Features/21_Glossary.md#L2-L1

tests/Unit/Document/Glossary/GlossaryTest.php

Removing glossary installed check

mattamon · 2022-12-28T14:08:19Z

Updating docs with new examples -> https://pimcore.com/docs/pimcore/11.0/Development_Documentation/Best_Practice/Open_By-External_Id.html

Removing if condition from buildmenu

doc/Development_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md

…pgrade_Notes/README.md

bundles/AdminBundle/config/pimcore/default.yaml

bundles/AdminBundle/public/js/pimcore/helpers.js

bundles/AdminBundle/public/js/pimcore/layout/menu.js

bundles/GlossaryBundle/config/pimcore/default.yaml

bundles/GlossaryBundle/public/js/glossary.js

mattamon · 2023-01-02T10:50:58Z

Added a section in the Upgrade Notes for all bundle extractions

Adding configuration for pimcore_glossary Removing helper function

Removing class dependency in migration

Changes adapted.

mattamon added 7 commits December 13, 2022 17:09

Extract glossary from core

5749dd3

Remove "use" of wrong installer

14cb7b4

Adding hook for keybinding registration

a320f4b

Adding migration for settings store Moving DependencyInjection Configuration back to Core

Remove permissions from installer

0b62c9c

Move translations to bundle

066a817

Move GlossaryTest back to tests

ba1f307

Making user keybindings configurable via yaml

2cb9eae

dvesh3 added the Task label Dec 16, 2022

dvesh3 added this to the 11.0.0 milestone Dec 16, 2022

Reorder loading files in jsPaths and extract permissions to constant

16efb2d

dvesh3 self-assigned this Dec 19, 2022

Add GlossaryBundle to ci/files/config/bundles.php

4ebbbd5

dvesh3 suggested changes Dec 21, 2022

View reviewed changes

mattamon added 4 commits December 22, 2022 08:36

Adding feedback changes

5ce3196

Adding warning to enable bundle manually Removing unnecessary interfaces Changing glossary.css to icons.css Changing route names

Adding feedback changes

d8b3b25

Reverting routes Adding bundle name to migration warning

Adding sorted menu

bbd97ea

Removing unecessary commas

df67c89

dvesh3 reviewed Dec 28, 2022

View reviewed changes

bundles/GlossaryBundle/src/Migrations/Version20221215071650.php Show resolved Hide resolved

dvesh3 mentioned this pull request Dec 28, 2022

Enable GlossaryBundle in bundles.php pimcore/demo#384

Closed

dvesh3 suggested changes Dec 28, 2022

View reviewed changes

dvesh3 reviewed Dec 28, 2022

View reviewed changes

tests/Unit/Document/Glossary/GlossaryTest.php Outdated Show resolved Hide resolved

mattamon added 5 commits December 28, 2022 13:28

Move migration to core/migrations

e564614

Update Documentation, to enable and install the bundle

4d52f92

Installing GlossaryBundle for testing

f9d1029

Refactoring installation to own method.

e667227

Removing glossary installed check

Merge branch '11.x' into 12517-move-glossary-to-bundle

ddbe493

mattamon added 3 commits December 28, 2022 15:24

Moving translation back into core

57a80d9

Removing if condition from buildmenu

Rename bundle from GlossaryBundle to PimcoreGlossaryBundle

0e0ede2

Adding Upgrade notes

1769ce8

dvesh3 reviewed Dec 28, 2022

View reviewed changes

doc/Development_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md Outdated Show resolved Hide resolved

Update doc/Development_Documentation/23_Installation_and_Upgrade/09_U…

2a0317c

…pgrade_Notes/README.md

dvesh3 approved these changes Dec 28, 2022

View reviewed changes

Adding extras menu by default and do not create if no items

a98c4b4

brusch previously requested changes Jan 2, 2023

View reviewed changes

mattamon added 3 commits January 2, 2023 14:54

Adding method to key_bindings

e2ce3cc

Adding configuration for pimcore_glossary Removing helper function

Renaming method to action

680d704

Removing class dependency in migration

Adding defaultkeybinding definition

333f0de

dvesh3 merged commit b864c79 into 11.x Jan 3, 2023

dvesh3 deleted the 12517-move-glossary-to-bundle branch January 3, 2023 08:44

dvesh3 mentioned this pull request Jan 5, 2023

[Task] Changing js class namespace, routing prefix and routing names #13959

Merged

kingjia90 mentioned this pull request Jan 10, 2023

[Task]: Remove empty Submenu when building menu #14020

Merged

Conversation

mattamon commented Dec 15, 2022 • edited by dvesh3 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes in this pull request

Additional info

Uh oh!

github-actions bot commented Dec 15, 2022 • edited by dvesh3 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review Checklist

Uh oh!

mattamon commented Dec 15, 2022

Uh oh!

brusch commented Dec 15, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dvesh3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mattamon commented Dec 28, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattamon commented Jan 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mattamon commented Dec 15, 2022 •

edited by dvesh3

Loading

github-actions bot commented Dec 15, 2022 •

edited by dvesh3

Loading

mattamon commented Jan 2, 2023 •

edited

Loading