Skip to content

[Improvement]: Remove space between QuantityValue value and unit #18312

@dolmit-tanel-paaro

Description

@dolmit-tanel-paaro

Improvement description

Suggestion to remove the space between the value and the unit.
It looks unnecessary because the space can be added by updating the translation.

Our project's needs are that in some locales there is space and in some there isn't.

The change:

-            $value .= ' ' . $translator->trans($this->getUnit()->getAbbreviation(), [], 'admin');
+            $value .= $translator->trans($this->getUnit()->getAbbreviation(), [], 'admin');

Ref: https://github.com/pimcore/pimcore/blob/12.x/models/DataObject/Data/QuantityValue.php#L63

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions