Add missing getConditionVariables() calls to listing DAOs#258
Merged
fashxp merged 20 commits intopimcore:1.3from Jun 12, 2025
Merged
Add missing getConditionVariables() calls to listing DAOs#258fashxp merged 20 commits intopimcore:1.3from
getConditionVariables() calls to listing DAOs#258fashxp merged 20 commits intopimcore:1.3from
Conversation
getConditionVariables() to listing DAOsgetConditionVariables() calls to listing DAOs
Contributor
Author
|
Any chance to get this bugfix into the next release? |
Member
|
could you please check sonar, thx. |
|
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Contributor
Author
|
Should be fine now. |
Member
|
thx very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the call is missing, you get an error when doing calls like
$list->setCondition('userid = ? AND name = ?', [$userId, $name]);because the values in the second parameter are ignored.Pimcore\Bundle\EcommerceFrameworkBundle\VoucherService\Token\Listing\Daois the only one where it's not missing.