Improve error messages by including the path#356
Closed
simhnna wants to merge 1 commit intopillarjs:masterfrom
Closed
Improve error messages by including the path#356simhnna wants to merge 1 commit intopillarjs:masterfrom
simhnna wants to merge 1 commit intopillarjs:masterfrom
Conversation
Without the path users need to search all their code for a malformed path or debug to find the issue Closes: pillarjs#336
Contributor
Author
|
Tried a couple of different places to include the path in the error message and I think prepending it is the easiest to read but if you'd like it somewhere else I'd update accordingly |
blakeembrey
reviewed
Apr 29, 2025
Member
blakeembrey
left a comment
There was a problem hiding this comment.
I appreciate this PR, it's a great direction! However I think it'd be good to avoid using stringify as it can output a different path to the original input, and instead add a originalPath or something to TokenData. I can open a PR you can review if that's OK?
Member
|
I've just merged #363 which adds the original path to the error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the path users need to search all their code for a malformed path or debug to find the issue
Closes: #336